openzim / cms

ZIM file Publishing Platform
https://cms.openzim.org
GNU General Public License v3.0
4 stars 0 forks source link

Better demo fixture #47

Closed anshulxyz closed 2 years ago

anshulxyz commented 2 years ago

Remove the previous test data and load fixtures again

rm src/dev.db && invoke db-upgrade load-demo-fixture

https://user-images.githubusercontent.com/6121530/148521055-f2da857a-c8cc-492e-a889-dbb61bb260a7.mp4

codecov[bot] commented 2 years ago

Codecov Report

Merging #47 (2585c68) into main (5e3c608) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 2585c68 differs from pull request most recent head 56ba7fb. Consider uploading reports for the commit 56ba7fb to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          222       222           
=========================================
  Hits           222       222           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e3c608...56ba7fb. Read the comment docs.

anshulxyz commented 2 years ago
Screenshot 2022-01-11 at 4 17 37 PM
anshulxyz commented 2 years ago

Please use <pre> nodes for Counter, as for books.

Fixing this in a different branch along with other frontend related changes. Will update this comment with the commit message when I push that.

rgaudin commented 2 years ago

Please use \<pre\> nodes for Counter, as for books.

Fixing this in a different branch along with other frontend related changes. Will update this comment with the commit message when I push that.

OK, we can fix that in a second PR.

anshulxyz commented 2 years ago

Please use \<pre\> nodes for Counter, as for books.

Fixing this in a different branch along with other frontend related changes. Will update this comment with the commit message when I push that.

OK, we can fix that in a second PR.

Hi @rgaudin I have fixed this in https://github.com/openzim/cms/commit/b7d58704184f96ae4a193d3720e7647575e9bf8c