search

openzim / cms

ZIM file Publishing Platform
https://cms.openzim.org
GNU General Public License v3.0
4 stars 0 forks source link

Update the Book size from Integer to BigInteger #54

Closed anshulxyz closed 2 years ago

anshulxyz commented 2 years ago

Closes #53

@rgaudin I ran the migration but the migration files was empty.

codecov[bot] commented 2 years ago

Codecov Report

Merging #54 (8e1b412) into main (535d704) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          249       249           
=========================================
  Hits           249       249
Impacted Files Coverage Δ
backend/src/backend/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 535d704...8e1b412. Read the comment docs.

rgaudin commented 2 years ago

@anshulxyz, I've fixed the alembix conf that I broke when introducing mysql support. Also added config so column type changes are checked in autogen (not default behavior) and I eventually added a third party that checks for difference between schema and models so that you can call db-gen in a similar way as Django.

Please check that we haven't missed any migrations and include the one for this

anshulxyz commented 2 years ago

Added the migration file for the change in datatype from int to BigInt for book's Size.

Please check that we haven't missed any migrations and include the one for this

@rgaudin I checked. No other change was made to models.py, that needs migration.