codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 96.18321% with 5 lines in your changes missing coverage. Please review.
Project coverage is 92.56%. Comparing base (
64a1c39) to head (353798e). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/devdocs2zim/generator.py | 94.11% | 3 Missing and 2 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #10 +/- ## =========================================== + Coverage 82.32% 92.56% +10.24% =========================================== Files 4 4 Lines 198 323 +125 Branches 19 43 +24 =========================================== + Hits 163 299 +136 + Misses 35 22 -13 - Partials 0 2 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
benoit74
Adds an MVP version of the generator: #1. With this, we get pretty nice support for most DevDocs items.
Known limitations:
third_partyassets are checked in and will need to be manually refreshed. Sadly, this info is only in the GitHub repo, but not the generated content ondevdocs.ioso there's a small window where it might become out of sync.ansiblewhich have very large number of entries in their navbars which causes Jinja to choke when instantiating and escaping tons of objects.libzimcompression is also slow: https://github.com/openzim/libzim/issues/544, we need some compression because images are base64 encoded and the navbars are repetitive, but doing so at the highest level is spending a bunch of time trying to further compress things with already high information density (e.g. JPEGs).Once merged, good proof of concepts for this would be: