openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
126 stars 37 forks source link

Fixed bookshelves related bugs #110

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

This PR does the following -

To make it easier to review -

rgaudin commented 4 years ago

Don't mix formatting and bug-fix otherwise this PR will have to be reviewed commit-by-commit !!!

Send a formatting-only PR first that we'll merge so that this becomes bug-fix only.

satyamtg commented 4 years ago

Don't mix formatting and bug-fix otherwise this PR will have to be reviewed commit-by-commit !!!

Send a formatting-only PR first that we'll merge so that this becomes bug-fix only.

Created #111 which only adds black formatting to python files

rgaudin commented 4 years ago

Another thing I just discovered ; could you please integrate this as well (so that we don't have static English strings there):

diff --git i/gutenbergtozim/templates/bookshelf.html w/gutenbergtozim/templates/bookshelf.html
index 593fd73..ac3298c 100644
--- i/gutenbergtozim/templates/bookshelf.html
+++ w/gutenbergtozim/templates/bookshelf.html
@@ -1,7 +1,7 @@
 {% extends "base.html" %}
-{% block title %}Individual Bookshelf{% endblock %}
+{% block title %}{{ bookshelf }}{% endblock %}
 {% block content %}
-<h1 class="table-title">{{ bookshelf }} Bookshelf</h1>
+<h1 class="table-title">{{ bookshelf }}</h1>
 <table class="data-table display" cellpadding="0" cellspacing="0" border="0" id="books_table"></table>
 <script type="text/javascript">
rgaudin commented 4 years ago

There's no review requested but I checked the rest and it's OK. We'll merge once you fix those strings in the template.