openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
126 stars 37 forks source link

JS code should not be part of the repository #116

Closed kelson42 closed 10 months ago

kelson42 commented 4 years ago

./gutenbergtozim/templates/datatables/DataTables-1.10.13/js ./gutenbergtozim/templates/datatables/Responsive-2.1.1/js

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

hksingh4545 commented 3 years ago

I want to work on this. Can you elaborate a little more about the issue?

satyamtg commented 3 years ago

@hksingh4545 sure, all you need to do is to remove those javascript dependencies from this repository and in place of that, introduce functionality to download those when running the scraper. This is done in other scrapers by introducing a get_js_deps.sh In other scrapers. See - https://github.com/openzim/ted/blob/master/get_js_deps.sh . Hope that helps.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

RaghavS8Y commented 1 year ago

Hi I would like to work on this issue!

Can you please guide me where can I get started?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.