search

openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
130 stars 37 forks source link

Do not force the presence of PDF format for all books #160

Open benoit74 opened 1 year ago

benoit74 commented 1 year ago

A few lines are forcing the presence of the PDF format for all books.

This is causing broken links / weird buttons in all books which do not have a PDF format.

Discussion on this issue already started here by mistake (my bad).

rgaudin commented 1 year ago

I don't understand this ticket. If it's independent to #159, does that mean that we have PDF files in ZIM files always? Even when we don't request them?

benoit74 commented 1 year ago

It is relatively independent from #159 It means that no matter the content of the RDF, the scraper consider there is always a PDF format available for all books. This causes the behavior you saw while testing #163 that when you request PDF among other export formats, you get many books with broken PDF buttons because the format is supposed to be there according to the bookformat table.

rgaudin commented 1 year ago

OK it's more clear: it fakes the availability of PDF for all books, even if there's no real PDF. Understood.

I don't see how it could affect #159 though but I believe we're not understanding each other on what #159 is about 😅

eshellman commented 1 year ago

FWIW, pdf generation at PG is planned for sometime this year.

On Jan 20, 2023, at 9:13 AM, rgaudin @.***> wrote:

OK it's more clear: it fakes the availability of PDF for all books, even if there's no real PDF. Understood.

I don't see how it could affect #159 https://github.com/openzim/gutenberg/issues/159 though but I believe we're not understanding each other on what #159 https://github.com/openzim/gutenberg/issues/159 is about 😅

— Reply to this email directly, view it on GitHub https://github.com/openzim/gutenberg/issues/160#issuecomment-1398451252, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHCGMNZGII62OOG6ZDPXYTWTKMPHANCNFSM6AAAAAAUAZHIDE. You are receiving this because you are subscribed to this thread.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.