openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
130 stars 37 forks source link

Improve favicon #165

Open kelson42 opened 1 year ago

kelson42 commented 1 year ago

We have only a minimal favicon but we should have a full favicon support for all possible devices. See https://realfavicongenerator.net/favicon_checker?protocol=https&site=library.kiwix.org%2Fcontent%2Fgutenberg_fr_all%2FA%2FHome.html

benoit74 commented 1 year ago

@eshellman, is it still appropriate to use this logo : https://commons.wikimedia.org/wiki/File:Project_Gutenberg_logo.svg converted in the various formats needed ?

@kelson42 @rgaudin could you point a scrapper already adding appropriate sizes / companion files (manifest, ...) so we could reuse the code?

kelson42 commented 1 year ago

openzim/phets has it implemented but this is in Typescript. AFAIK, no Python scraper has implemented this so far.

eshellman commented 1 year ago

pg-logo-144x144-original pg-logo

rgaudin commented 1 year ago

@eshellman could you share the source of those images? Or at least higher resolution images. We'd need 512x512 for the large one and 48x48 for the simplified version (according to that website).

Is it only somewhere? Who's the author/license?

Finally, should the light color on the edges be removed (ie. have a rounded square on top of transparent background) ?

eshellman commented 1 year ago

I'll track that down. I have a transparent edge version of the png too. pg-logo-144x144-transparent

kelson42 commented 1 year ago

@eshellman Thx, I guess we have now the data material to move forward!?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

benoit74 commented 1 year ago

Nope, as mentioned and detailed here https://github.com/gbnewby/gutenbergsite/issues/24#issuecomment-1683818588 we would benefit from an online file + a file in higher resolution.

benoit74 commented 1 year ago

Good online resources to understand files / resolutions needed / recommended / expected:

Should we :

  1. use RealFaviconGenerator API at https://realfavicongenerator.net/api/non_interactive_api everytime the scraper runs in order to generate proper data with explicit settings
  2. generate HTML / files with RealFaviconGenerator once and embed it in the scraper code (meaning we will have to run it again at a regular interval)

I prefer option 2 because it reduces greatly our dependency on an online service which might disappear + allow us to easily switch to another one / tweak the result if needed + it allows more easily to upscale the source image used to generate other ones manually with AI or other tools manually before starting the process

benoit74 commented 1 year ago

I upscaled the image with https://imgupscaler.com/ (randomly chosen, no strong experience on those tools) and it gave very decent result even if some zones are a bit blurry. Resulting image is 516x516 ... sic

gutenberg_favicon_upscaled

mrcook commented 1 year ago

By the looks of things this is an Albion Hand Press: image

I'm sure the font would be easy to reproduce. Your favourite search engine would likely produce an un-watermarked image.

eshellman commented 1 year ago

wow, that's pretty good!