Migrate to new PG server + remove inline JS + remove JS deps from repo

openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg

https://download.kiwix.org/zim/gutenberg

GNU General Public License v3.0

126 stars 37 forks source link

Migrate to new PG server + remove inline JS + remove JS deps from repo #189

Closed benoit74 closed 10 months ago

benoit74 commented 10 months ago

Fix #187 Fix #145 Fix #116 Fix #162

Changes

use aleph.pglaf.org instead of dante.pglaf.org to accomodate PG infra changes
move inline JS (body onload + goToAuthor) to tools.js
get DataTables (+ Responsive) JS deps at build time instead of storing them in the repo
upgrade to DataTables 1.13.6 + Responsive 2.5.0
upgrade Docker image to python:3.11.4-bookworm

This change is

Jaifroid commented 10 months ago

I'd be happy to test a ZIM against Kiwix JS browser extension.

Jaifroid commented 10 months ago

That been said, I did not encountered any issue with Kiwix JS on my Firefox (Kiwix JS 3.9.0, Firefox 115.0.2, Mac OS Monterey 12.6.7) and the latest dev ZIM (https://mirror.download.kiwix.org/zim/.hidden/dev/gutenberg_en_all_2023-03.zim), i.e without removing inline JS, so I'm not sure about what has to be tested.

The issue with inline JS is in the Chrome extension, not the Firefox extension. For security reasons, inline JS is banned in that context. Are you able to provide a small ZIM archive I could test in that context? The Romanian language scrape of Gutenberg is quite small for instance. (a few MB).

kelson42 commented 10 months ago

Kudos! Looks good to merge then :)

benoit74 commented 10 months ago

@Jaifroid I will provide you small ZIMs of the three scrappers I've modified tomorrow so that you can test them, I have lots of options to generate small ZIMs on my machine 😄

benoit74 commented 10 months ago

I will merge as-is this PR, hence marking the issue as closed, follow-up on tests will be done on https://github.com/kiwix/kiwix-js/issues/865 and we will create a new issue should something bad be found.