search

openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
126 stars 37 forks source link

Upgrade all dependencies #202

Open benoit74 opened 10 months ago

benoit74 commented 10 months ago

Upgrade Python + JS + CSS dependencies to latest versions

Siddu24294 commented 3 months ago

I would like to work on this.. I believe the way to go about this is:

  1. update the .toml file to update the dependencies written.
  2. Check if any changes are to be done in hatchback and tasks python files related to the updated modules.
  3. Run tests to check if it works
  4. submit the PR.

The only I Have is whether i have to upgrade dependencies to their latest version or to a specific version? If to a specific version then which version?

benoit74 commented 3 months ago

@Siddu24294 this is the way to go.

With one minor drawback you need to be aware of: there is no automated tests, so you will have to run the scrapper manually and confirm it still works as intended by going through the ZIM. And comparing it with another ZIM you would have built before the update.

I suggest that you start with it: run the scrapper with current codebase and understand how it works and what it the ZIM current behavior (we have some known bugs, including very visible ones like #219)

Siddu24294 commented 3 months ago

Thanks for the guidance, I will get to work.