Closed MUCCHU closed 5 months ago
Attention: 89 lines
in your changes are missing coverage. Please review.
Comparison is base (
2fd98ed
) 0.76% compared to head (31eed63
) 0.77%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nota: black formatting is not OK as well ; you should probably:
hatch shell
(if not already done)pre-commit install
in base repo folder) to detect such issues at commit timeinvoke fixall
(in base repo folder again)Thank you for the feedback. I made all the changes you requested and also ensured that the formatting is perfect by enabling pre-commit. Kindly review the PR.
I really like what you did, good job. Just give me some time to start an end-to-end test and I will come back to you.
Still did not had time to start a test run, sorry about that.
Closed for inactivity, feel free to reopen if you have new changes to submit.
Fix #195
Make sure consistency is maintained by using
pathlib.Path
to handle all file operations.After the changes I ran the docker container which worked perfectly fine.