Closed elfkuzco closed 2 months ago
Attention: Patch coverage is 16.66667%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 0.75%. Comparing base (
4ac977c
) to head (bfd801b
).
Files | Patch % | Lines |
---|---|---|
src/gutenberg2zim/entrypoint.py | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rationale
Normalize all log outputs to be under one name instead of module specific loggers and add
--debug
flag for more verbose output. This is intended to be a fix for #206 .Changes
INFO
instead ofDEBUG
--debug
flag to dynamically set level toDEBUG
--debug
flag is set, update the handlers to have their levels set toDEBUG
as a simplelogger.setLevel(logging.DEBUG)
only sets it for the logger and not for the handlers. This is akin to what thegetLogger
function fromzimscraperlib
does. After all, it is the handlers that handle output and not thelogger
object.