Replace usage of os.path and path.py with pathlib

openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg

https://download.kiwix.org/zim/gutenberg

GNU General Public License v3.0

126 stars 37 forks source link

Replace usage of os.path and path.py with pathlib #225

Closed elfkuzco closed 2 months ago

elfkuzco commented 2 months ago

Fixes #195

Rationale

Use pathlib.Path for all path operations instead of a combination of os.path and path.py.

Changes

Replace all usages of os.path and path.py to pathlib.Path
Add type annotations for some parts of the code
Use f-strings to build urls instead of os.path.join

elfkuzco commented 2 months ago

@benoit74 , I have made the necessary fixes but I'm unable to run the full check anymore as my VM instance on GCP keeps running out of space (over 20Gb). However, I can verify that the previous commands run to full completion

benoit74 commented 2 months ago

I have made the necessary fixes but I'm unable to run the full check anymore as my VM instance on GCP keeps running out of space (over 20Gb). However, I can verify that the previous commands run to full completion

That's enough for me, we will make a full run before releasing this anyway.