search

openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
128 stars 37 forks source link

Site just displays the loading spinner #4

Closed rashiq closed 7 years ago

rashiq commented 10 years ago

The commit e993ffcb294e7f2cbe02a55305e7f443f8301d01 by @kelson42 broke the site. It's only displaying the loading-spinner now.

bildschirmfoto 2014-07-19 um 22 05 17

Reproduce it by exporting the site:

./dump-gutenberg.py --export -l en

I have tested this on Chrome, Firefox and Safari.

kelson42 commented 10 years ago

Just change the script.src assignement in tools.js for testing without zim.

On 07/19/2014 10:06 PM, Rashiq Ahmad wrote:

The commit e993ffc https://github.com/kiwix/gutenberg/commit/e993ffcb294e7f2cbe02a55305e7f443f8301d01 by @kelson42 https://github.com/kelson42 broke the site. It's only displaying the loading-spinner now.

bildschirmfoto 2014-07-19 um 22 05 17 https://cloud.githubusercontent.com/assets/1624385/3635610/084b447a-0f80-11e4-99bf-d70687bd6f78.png

— Reply to this email directly or view it on GitHub https://github.com/kiwix/gutenberg/issues/4.

rashiq commented 10 years ago

works :+1:

Seb35 commented 10 years ago

This should better handled with some test in JS, but I don’t know how to test if we are in Kiwix or in a browser.

kelson42 commented 10 years ago

If you have a test case, this is welcomed ;) To my opinion, there is no clean way to test this in JS. A solution would be to make this switch/choice in Python, just before and only for the zimification of the content (templatify tools.js?).