openzim / gutenberg

Scraper for downloading the entire ebooks repository of project Gutenberg
https://download.kiwix.org/zim/gutenberg
GNU General Public License v3.0
130 stars 37 forks source link

Adds german translations. #58

Closed AVGP closed 6 years ago

AVGP commented 6 years ago

refs #56

kelson42 commented 6 years ago

@AVGP Thx for the PR!

dattaz commented 6 years ago

Hello, Thanks a lot for you PR ! Can you add initialization for german please ? (see https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/templates/l10n/locales.ini and also here https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/export.py#L40 )

AVGP commented 6 years ago

@dattaz done :shipit:

dattaz commented 6 years ago

Thanks :+1: :fireworks:

dattaz commented 6 years ago

@AVGP Hi, we found with your PR that we have 2 system for translations, I am unifying them, but i'm missing some german strings, can you give me them by comment here ? Thanks.

"Interface language" : (https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L26) "List books of a single Author" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L33 ) "Choose the Catalog" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L79 ) "Main languages" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L82 ) "Other languages" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L85 )

kelson42 commented 6 years ago

@dattaz done https://github.com/openzim/gutenberg/commit/c663232e372942839b8849e38744c88c4a6c6b5f