openzim / ifixit

iFixit to ZIM scraper
GNU General Public License v3.0
25 stars 3 forks source link

Some missing guides are not added because of missing title which is indeed known #75

Closed benoit74 closed 2 years ago

benoit74 commented 2 years ago

Scenario:

This scenario happened on 9th of May 2022 but seems to be linked to a change between the 'jbl_partybox' category scraping and the guide 149003 scraping. Looks like the guide has been removed in-between.

Since it will continue to happen, it might be great to retrieve the guide title while normalizing URLs (

kelson42 commented 2 years ago

These kind of scenarios are mean. If something can be build without complexifying too much the code then it should be done. Otherwise, we use, to just live with this kind of imperfection.

benoit74 commented 2 years ago

Agreed about the fact this is very mean 🤣 And agreed about the fact that we should not add too much complexity to fix this, since it is a real edge case.

benoit74 commented 2 years ago

Won't fix for now, let's see if this happens too much (consequence is limited anyway)