Closed benoit74 closed 7 months ago
Attention: 31 lines
in your changes are missing coverage. Please review.
Comparison is base (
cb214f4
) 29.75% compared to head (04fcdff
) 29.42%. Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/kolibri2zim/scraper.py | 25.00% | 27 Missing :warning: |
src/kolibri2zim/entrypoint.py | 25.00% | 3 Missing :warning: |
src/kolibri2zim/processing.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rationale
Fix #82
83 is not fully fixed but the situation is way better (we start only one ffmpeg process per scraper run), the rest will be done by https://github.com/openzim/python-scraperlib/issues/123
Changes
--processes
(code detecting the Docker usage was not working anymore and is mostly useless since ffmpeg is already pushing a lot of pressure on the CPU + we usually run inside Docker and do not want multiple ffmpeg instance at the same time, even if they use only one CPU thread)Tests
This has been tested with:
First call re-encodes and uploads the video, second call uses S3 file.