openzim / kolibri

Convert a Kolibri channel in ZIM file(s)
GNU General Public License v3.0
8 stars 12 forks source link

Upgrade dependencies including new bootstrap conventions #87

Closed benoit74 closed 7 months ago

benoit74 commented 7 months ago

Fix #83 Fix #75 (both are fixed by upstream change in python-scraperlib 3.3.0)

Changes

Tests

A test ZIM has been made with following command (OPTIM_CACHE points to org-kiwix-dev-kolibri)

docker run --rm -it -v $PWD/output:/output local-kolibri2zim kolibri2zim --name "minimal_test" --title "Minimal Kolibri Channel Test" --description "This is a minimal Kolibri Channel" --channel-id "7f744ce8d28b471eaf663abd60c92267" --debug --low-quality --use-webm --optimization-cache $OPTIM_CACHE
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7d55752) 29.42% compared to head (243f285) 29.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== + Coverage 29.42% 29.69% +0.26% ========================================== Files 6 6 Lines 751 751 Branches 134 130 -4 ========================================== + Hits 221 223 +2 Misses 522 522 + Partials 8 6 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benoit74 commented 7 months ago

Build is failing until hatch-openzim 0.2.0 is released (https://github.com/openzim/hatch-openzim/issues/11 issue)

benoit74 commented 7 months ago

hatch-openzim 0.2.0 released, CI is OK now

benoit74 commented 7 months ago

As usual, I forgot to update the CHANGELOG, done now, sorry