search

openzim / kolibri

Convert a Kolibri channel in ZIM file(s)
GNU General Public License v3.0
8 stars 13 forks source link

fix issue 71 #98

Closed githyuvi closed 4 months ago

githyuvi commented 4 months ago

closes issue #71

Tested with African StoryBook Library Zim

https://github.com/openzim/kolibri/assets/96630446/7d574be7-6f97-4846-8442-63ff2f846b0a

githyuvi commented 4 months ago

commit 2d8e689 adds the following functionality. left arrow is disabled for slide index = 0 and right arrow is disabled for slide index = last slide index.

benoit74 commented 4 months ago

I fucked-up the rebase, and the PR, I've just reopened it, sorry

benoit74 commented 4 months ago

@githyuvi one small remark: you should not commit to your new_ui branch but checkout a specific new branch for each issue (or set of issues) you wanna work on, and give a "meaningful" name to this branch

githyuvi commented 4 months ago

@benoit74 sure👍