openzim / libzim

Reference implementation of the ZIM specification
https://download.openzim.org/release/libzim/
GNU General Public License v2.0
164 stars 50 forks source link

Make search remove accents from the queried string. #804

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

Fix kiwix/libkiwix#953

This is libzim (through defaultIndexer) which removing accents at indexation. We should do the same when searching.

mgautierfr commented 1 year ago

I would split the change in two commits: […]

Done

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (d87ff0d) 57.48% compared to head (a83edfe) 57.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #804 +/- ## ========================================== - Coverage 57.48% 57.47% -0.02% ========================================== Files 98 98 Lines 4540 4541 +1 Branches 1909 1910 +1 ========================================== Hits 2610 2610 Misses 674 674 - Partials 1256 1257 +1 ``` | [Impacted Files](https://app.codecov.io/gh/openzim/libzim/pull/804?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim) | Coverage Δ | | |---|---|---| | [src/search.cpp](https://app.codecov.io/gh/openzim/libzim/pull/804?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3NlYXJjaC5jcHA=) | `48.10% <0.00%> (-0.31%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.