search

openzim / libzim

Reference implementation of the ZIM specification
https://download.openzim.org/release/libzim/
GNU General Public License v2.0
164 stars 50 forks source link

Fix indexation of CJK languages. #806

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

Fix #802

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.03 :warning:

Comparison is base (c9d5e9a) 57.49% compared to head (0f0016c) 57.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #806 +/- ## ========================================== - Coverage 57.49% 57.46% -0.03% ========================================== Files 98 98 Lines 4526 4528 +2 Branches 1901 1903 +2 ========================================== Hits 2602 2602 Misses 674 674 - Partials 1250 1252 +2 ``` | [Impacted Files](https://app.codecov.io/gh/openzim/libzim/pull/806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim) | Coverage Δ | | |---|---|---| | [src/search.cpp](https://app.codecov.io/gh/openzim/libzim/pull/806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3NlYXJjaC5jcHA=) | `48.40% <0.00%> (ø)` | | | [src/writer/xapianIndexer.cpp](https://app.codecov.io/gh/openzim/libzim/pull/806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3dyaXRlci94YXBpYW5JbmRleGVyLmNwcA==) | `30.88% <0.00%> (-0.47%)` | :arrow_down: | | [src/writer/xapianWorker.cpp](https://app.codecov.io/gh/openzim/libzim/pull/806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3dyaXRlci94YXBpYW5Xb3JrZXIuY3Bw) | `32.50% <0.00%> (-0.84%)` | :arrow_down: | | [src/suggestion.cpp](https://app.codecov.io/gh/openzim/libzim/pull/806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3N1Z2dlc3Rpb24uY3Bw) | `45.38% <33.33%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kelson42 commented 1 year ago

@mgautierfr Can you please provide an index size benchmark? @xiaoyifang Could you please confirm this fix the issue you have open (hope you are able to build a test ZIM file)?

veloman-yunkan commented 1 year ago

Also, do you have an explanation for why the codecov/patch flow has failed?

mgautierfr commented 1 year ago

Also, do you have an explanation for why the codecov/patch flow has failed?

For a unknown reason (maybe the assert at the beginning of function ?), codecov thinks the line are partially tested. Maybe it is not totally counted as tested and, as we add new lines, the coverage decrease.