Closed mgautierfr closed 1 year ago
should || defined __CYGWIN__
be removed ,if it can work before?
(kiwix-build kiwix-tools --target-platform win32_dyn) ?
how dows kiwix-build get the latest libzim source_code?
Setting LIBZIM_API
only if we compile with Ms Compiler seems to work (at least on Cygwin).
@xiaoyifang can you test #807 on Windows to be sure it doesn't brake on Windows ?
Ok ,I'll let you know when I tested
This is how vcpkg community handled this.
if defined(_MSC_VER) && defined(LIBZIM_EXPORT_DLL)
This can work on windows.
But I would recommend changes like this
such as
+if host_machine.system() == 'windows' and get_option('default_library') == 'shared'
+ public_conf.set('LIBZIM_EXPORT_DLL', true)
+endif
+
@mgautierfr Can we foreseen to fix this today:
8.2.1
release@xiaoyifang I will merge #807 anyway as it fix our current problem.
I'm not sure about your solution, as it will set decl(export)
on gcc cross-compilation to windows and we don't want that.
@mgautierfr What's up here? We need to release 8.2.1
ASAP.
This is fixed by #807
The last change made in https://github.com/openzim/libzim/pull/796 seems broken. The PR #807 add some ddl export of forgotten symbol.
But it seems it brokes something on the compilation of kiwix-tools. Now we have a lot (if not all) of libkiwix symbols not found. I don't know why.
@xiaoyifang can you try to compile kiwix-tools on windows ? Or do a cross-compilation to win32 if you are on linux (
kiwix-build kiwix-tools --target-platform win32_dyn
) ?