openzim / libzim

Reference implementation of the ZIM specification
https://download.openzim.org/release/libzim/
GNU General Public License v2.0
166 stars 49 forks source link

Check on all supported macOS versions #832

Closed kelson42 closed 11 months ago

kelson42 commented 11 months ago

Better architecture and system coverage for macOS/iOS related CI

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (13571d7) 57.57% compared to head (e139fc2) 57.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #832 +/- ## ======================================= Coverage 57.57% 57.57% ======================================= Files 98 98 Lines 4545 4545 Branches 1911 1911 ======================================= Hits 2617 2617 Misses 668 668 Partials 1260 1260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 11 months ago

@mgautierfr Do you know why a few macOS fail?

mgautierfr commented 11 months ago

Failling CI is crosscompiling from macos-13 to iOS. Cross compiling use a "meson_cross_file" file found in https://tmp.kiwix.org/ci/deps2_osx_iOS_x86_64_libzim.tar.xz (step "Install Deps") generated by kiwix-build. This file tells which compiler to use.

I suppose that this archive is build by kiwix-build for macos-12 and that the binaries paths have changed between macos-12 and macos-13

kelson42 commented 11 months ago

OK, then I would create a dedicated ticket for that scenario and don't do it for the moment. At the release of macOS 15, then it will be a topic.

kelson42 commented 11 months ago

@mgautierfr @rgaudin macos-13-xlarge (M1) keeps failing, but no log. Wonder what is going on here. Any idea?

rgaudin commented 11 months ago

We need units in our account ; that's in the logs

rgaudin commented 11 months ago

I don't recall exactly the message and I'm on my phone but it's something like that. M1 large are supposed to be in beta and free though

kelson42 commented 11 months ago

@rgaudin I have commented-out the M1 testing as long as whole stuff is in beta. I'm not confortable to rely on an none-prod-ready service.

kelson42 commented 11 months ago

We are almost good, do you know what trigger the 3 pending macos jobs?