Closed kelson42 closed 5 months ago
@mgautierfr why the CI fails? Something missing in the deps?
@mgautierfr why the CI fails? Something missing in the deps?
As the log says:
ld: warning: ignoring file '/Users/runner/BUILD_native_dyn/INSTALL/lib/liblzma.5.dylib': found architecture 'x86_64', required architecture 'arm64'
ld: warning: ignoring file '/Users/runner/BUILD_native_dyn/INSTALL/lib/libzstd.1.dylib': found architecture 'x86_64', required architecture 'arm64'
ld: warning: ignoring file '/Users/runner/BUILD_native_dyn/INSTALL/lib/libxapian.30.dylib': found architecture 'x86_64', required architecture 'arm64'
ld: warning: ignoring file '/Users/runner/BUILD_native_dyn/INSTALL/lib/libicui18n.73.2.dylib': found architecture 'x86_64', required architecture 'arm64'
ld: warning: ignoring file '/Users/runner/BUILD_native_dyn/INSTALL/lib/libicuuc.73.2.dylib': found architecture 'x86_64', required architecture 'arm64'
ld: warning: ignoring file '/Users/runner/BUILD_native_dyn/INSTALL/lib/libicudata.73.2.dylib': found architecture 'x86_64', required architecture 'arm64'
This is because os name macos
is the same for macos-13
and macos-14
and they are not the same architecture. (Without speaking that kiwix-build is not running on macos-14
)
This is because os name
macos
is the same formacos-13
andmacos-14
and they are not the same architecture. (Without speaking that kiwix-build is not running onmacos-14
)
Thx, so if I get it right a victim of this implicit, unclear, context dependent fake target native_xyz
?
@mgautierfr Now, the targets have proper clear name (I believe so at least) but seems the data have to be generated with proper name somewhere else, I guess in kiwix-build!
@mgautierfr What should we do with this PR now?
With last update on kiwix-build side, we can now compile on M1/MacOS14 (aarch64) with the dependencies build by kiwix-build (cross-compiled from x86_64(macos13) to aarch64).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #856 +/- ## ========================================== - Coverage 58.07% 57.60% -0.47% ========================================== Files 101 99 -2 Lines 4622 4590 -32 Branches 1920 1922 +2 ========================================== - Hits 2684 2644 -40 - Misses 665 677 +12 + Partials 1273 1269 -4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.