Closed mgautierfr closed 3 months ago
Attention: Patch coverage is 46.15385%
with 28 lines
in your changes are missing coverage. Please review.
Project coverage is 58.01%. Comparing base (
96afb38
) to head (54a3e6c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Didn't you also have to replace all cURLy braces with PArenTHeses? :)
I've tried. But gcc didn't want. Hope next version of cpp will allow this.
Dirents' "url" are not really url. They are u8 arrays which serve as the main "key". Specification says that this u8 array store a utf-8 encoded string and we use this key as a path.
Public API already use path semantic so rename all internal symbols from url to path.
Fix #868