Add some unittest on get_buffer

openzim / libzim

Reference implementation of the ZIM specification

https://download.openzim.org/release/libzim/

GNU General Public License v2.0

163 stars 47 forks source link

Closed mgautierfr closed 1 month ago

mgautierfr commented 1 month ago

This Pr was initially to fix #886. But it appears it was not a bug on our side.

However, it is better testing and it reveals some bug on Windows side.

kelson42 commented 1 month ago

Where is rhe codecov, it seems it has vanished!

rgaudin commented 1 month ago

I think it doesn't run on drafts

mgautierfr commented 1 month ago

Done

mgautierfr commented 1 month ago

Looks good to me but not to my more picky self :)

Done. Hope picky @veloman-yunkan is happy with the change.

Please merge after addressing the two concerns with the commit history

I need a explicit approval to merge. Please approve (and merge directly while you have the button under your mouse cursor)