search

openzim / libzim

Reference implementation of the ZIM specification
https://download.openzim.org/release/libzim/
GNU General Public License v2.0
163 stars 47 forks source link

Correctly test invalid offsets in clusters. #895

Closed mgautierfr closed 1 month ago

mgautierfr commented 1 month ago

This offset test in the cluster is to check that value parsed are consistent. This is not to catch a potential bug in our code.

So we must throw a ZimFileFormatError in this case.

Extend the validate function to test this kind of corrupted offset.

Need openzim/zim-testing-suite#9 Fix #893

kelson42 commented 1 month ago

@mgautierfr Both macOS and Windows CI don't pass.

mgautierfr commented 1 month ago

I know. It is because we need a new version of zim-testing-suite (which is blocked by openzim/zim-testing-suite#10) and https://github.com/kiwix/kiwix-build/pull/706

kelson42 commented 1 month ago

@mgautierfr What is the status here? Testing auite has been released, but the CI still fails... and acutally I wanted to release 9.2.2 this WE.

kelson42 commented 1 month ago

I have:

I will merge