Update test files - Githubissues

openzim / libzim

Reference implementation of the ZIM specification

https://download.openzim.org/release/libzim/

GNU General Public License v2.0

166 stars 49 forks source link

Update test files #910

Open tusharpm opened 2 months ago

tusharpm commented 2 months ago

counterParsing

replace macro with global variable

defaultIndexdata

replace arithmetic operations with floating point comparison macro

error_in_creator

reduce duplication of template test parameters as described in the comment

parseLongPath

succinct assertions using tuple value comparisons

kelson42 commented 1 month ago

@mgautierfr Can you please review?

tusharpm commented 1 month ago

Thanks for the review @veloman-yunkan. I was working on another change to include icu.wrap in subprojects, however, decided to PR these changes separately. The commit message included both by mistake. I've amended, rebased and force-pushed the changes. There's no specific issue being resolved in this PR - just code simplification.

veloman-yunkan commented 1 month ago

@tusharpm I think that the commit message is still somewhat misleading - it creates an impression that something had changed in the API, dependencies, compiler, etc, so the test files had to be updated to keep things working. Please change the commit message to "Some clean-up in test files" and we will merge the PR.