search

openzim / mindtouch

libretexts.org to ZIM scraper
GNU General Public License v3.0
0 stars 0 forks source link

Add overwrite option #3

Closed benoit74 closed 2 weeks ago

benoit74 commented 3 weeks ago

Add option to overwrite existing ZIM

Please review and merge #1 first

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (9fa9b7a) to head (a3cd390). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/libretexts2zim/processor.py 0.00% 2 Missing :warning:
scraper/src/libretexts2zim/entrypoint.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3 +/- ## ========================================== - Coverage 57.20% 56.72% -0.49% ========================================== Files 7 7 Lines 236 238 +2 Branches 19 19 ========================================== Hits 135 135 - Misses 100 102 +2 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benoit74 commented 2 weeks ago

Please make the PR target that other PR branch next time. It allows incremental update and github automatically switches the target once the base PR is merged.

Oh, cool, didn't knew about it (or already forgot ...). Thank you, will do

Should we remove the file before starting the creator or just as currently rely on libzim's overwritting (at a point we dont exactly control)?

Yes indeed we should probably delete it at the moment we check we are allowed to overwrite, otherwise it might be confusing in some scenario.