Closed benoit74 closed 2 weeks ago
Attention: Patch coverage is 17.85714%
with 92 lines
in your changes missing coverage. Please review.
Project coverage is 44.94%. Comparing base (
8efbbe5
) to head (40cb342
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I find we're duplicating the cache reading/writing bits ; maybe room for sharing this
This is probably because some of the code was buggy ^^ I fixed this. There is indeed only small variations ... but pretty important ones.
I had to rebase to fix conflicts. Please review only two last commits which contains "real" modifications.
Nota: Iast commit is about making codecov informational. I find it's mostly mandatory since in scrapers like this one, most code is covered by integration tests, but these are not reported in codecov ...
Changes:
Nota: this is not yet used to populate anything in the ZIM, only "utility" code for now
To be reviewed after https://github.com/openzim/libretexts/pull/3 is merged