Closed benoit74 closed 1 month ago
Attention: Patch coverage is 9.37500%
with 29 lines
in your changes missing coverage. Please review.
Project coverage is 40.54%. Comparing base (
c2a6444
) to head (a55f69b
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
scraper/src/mindtouch2zim/processor.py | 9.67% | 28 Missing :warning: |
scraper/src/mindtouch2zim/entrypoint.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix #37
Changes:
--debug
is not passed, we have visual feedback that scraper is still progressing)Remarks: we add 1 more items to process so that progress is not 100% at the beginning when we do not yet know how many items we have to process and so that we can increase counter at the beginning of every for loop, not minding about what could happen in the loop in terms of exit conditions