search

openzim / mwoffliner

Mediawiki scraper: all your wiki articles in one highly compressed ZIM file
https://www.npmjs.com/package/mwoffliner
GNU General Public License v3.0
296 stars 74 forks source link

Bad error reporting when old redis tables #1906

Open kelson42 opened 1 year ago

kelson42 commented 1 year ago

I get this kind of reports:

[error] [2023-09-13T18:57:24.423Z] Found store from previous run from Mon Sep 11 2023 20:02:57 GMT+0200 (Central European Summer Time) that is still in redis: 1694455377607-media with length 86
[error] [2023-09-13T18:57:24.424Z] Found store from previous run from Mon Sep 11 2023 20:02:57 GMT+0200 (Central European Summer Time) that is still in redis: 1694455377607-detail with length 1
[error] [2023-09-13T18:57:24.424Z] Found store from previous run from Mon Sep 11 2023 20:02:57 GMT+0200 (Central European Summer Time) that is still in redis: 1694455377607-redirect with length 13

This is not an error, at best this should be a warning.

I also challenge the why this is printed if the user can not do anything about it. These old tables should better be just deleted.

AKACHI-4 commented 9 months ago

hey @kelson42, I want to take on that issue could you tell me what brings you on those error tables, and what should I focus on while resolving, to remove appearing those errors or transform them into warning instead of error. ?

jairajmahadev commented 7 months ago

@kelson42 any update on this issue? Can we just flush all redis tables after the operation is completed?