search

openzim / mwoffliner

Mediawiki scraper: all your wiki articles in one highly compressed ZIM file
https://www.npmjs.com/package/mwoffliner
GNU General Public License v3.0
276 stars 72 forks source link

Double check code coverage reporting #2060

Open audiodude opened 3 months ago

audiodude commented 3 months ago

In #2055 I got a notification that the line I changed was missing coverage:

image

However when I added a log statement here I could see that the code was being executed by this test

Perhaps e2e tests are not being counted for coverage?

audiodude commented 3 months ago

Actually that doesn't make sense, because it is a unit test.

kelson42 commented 3 months ago

unit test code should be excluded of code coverage. We fix that in the config yml file for codecov.

audiodude commented 2 months ago

What I meant was, the test I linked to is a unit test, so my hypothesis that "e2e tests are not generating coverage" is definitely wrong.