search

openzim / nautilus

Turns a collection of documents into a browsable ZIM file
GNU General Public License v3.0
19 stars 14 forks source link

Support video files and more audio extensions #2

Closed rgaudin closed 4 years ago

rgaudin commented 4 years ago

ATM only ogg files (audio) triggers the modal dialog which renders using an <audio /> node. We should trigger this on most common audio extensions and we should also trigger it (although with <video /> for video files.

HAKSOAT commented 4 years ago

Hello @rgaudin Is there some sort of processing we use that's just for ogg files at the moment? Such that if we allow other files may cause the code to break. Or is it just a case of allowing more extensions?

rgaudin commented 4 years ago

No, we use video.js which supports whatever the browser supports. In addition, we use ogv.js with videojs-ogvjs to support ogg audio and video.

this ticket is just to enable the audio/video player for most common audio and video extensions that one could you in a ZIM.

In the ZIM we create ourselves, we only use ogg because that's the only way to support all platforms but others are free to use regular formats like mp3/mp4.