search

openzim / nautilus

Turns a collection of documents into a browsable ZIM file
GNU General Public License v3.0
19 stars 14 forks source link

Trust collection as source for files #33

Closed Popolechien closed 4 months ago

rgaudin commented 2 years ago

Currently, nautilus takes all files from the ZIP and add them to the ZIM file. Then, it builds an index using the collections.json ; assuming there is a perfect match between in-ZIP paths and the collection.

A more user-realistic approach would be to trust the collection and work off it: for each file listed in the collection, extract the matching entry in ZIP and add it to the ZIM.

This will have the benefit of identifying early (by failing) when there is a mismatch between collection and ZIP content. It would also allow selections from the same ZIP file, without wasting space

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 4 months ago

@rgaudin @Popolechien Not sure about the exact status of this issue as I don't fully understand it and is already pretty old. What should we do next?

rgaudin commented 4 months ago

Checked source code ; this has been implemented