openzim / nautilus

Turns a collection of documents into a browsable ZIM file
GNU General Public License v3.0
19 stars 14 forks source link

Video content should be given with a wallpaper #55

Closed kelson42 closed 1 year ago

kelson42 commented 1 year ago

If I try to look to a video, I get this (before clicking on the "play" button) image

I want to have a proper image displayed in place of this grey box.

Either this is delivered in the json or we should find a way to capture one from the video stream.

rgaudin commented 1 year ago

The player displays the first frame of the video as cover. This series of videos happen to start with a blank grey image.

We could extract any random frame to create a dedicated thumbnail but we'd loose control over what gets picked up while every video tool uses the first frame (unless they allow choosing one). That's what's expected.

I am thus in favor of closing this. We could remove the blank frames and redo this ZIM as well.

Screenshot 2023-05-04 at 14 41 42
kelson42 commented 1 year ago

Not sure how the solution should look like but I know we should not display a grey or black box for a video.

Using the first frame of a video is not what I expect, and it's not how it works usually. See Youtube, Netflix, etc.

I think the reason is obvious: it's just not what user expect, they want to get a picture which give an idea - is representive - of the content.

We should:

rgaudin commented 1 year ago

Closing in favor of #56 #57