search

openzim / nautilus

Turns a collection of documents into a browsable ZIM file
GNU General Public License v3.0
19 stars 14 forks source link

Add urls support to collections. #62

Closed FledgeXu closed 1 year ago

FledgeXu commented 1 year ago

Fix #59

FledgeXu commented 1 year ago

The problem is you are looking for duplicates in path instead of filename. path is used only to retrieve member_name (maybe it should be renamed) and we don't care about using it multiple times.

I see. you are right, filename is the name of the last file that will be put into zim.

rgaudin commented 1 year ago

You may also want to only display duplicate ones (using a set) ; otherwise

ValueError: Files in collection are duplicate:
 - test.pdf
 - test.pdf

You should also look into refactoring a bit test_collection to please Codefactor

FledgeXu commented 1 year ago

maybe it should be renamed

I just changed the path to the uri. I think it's more appropriate.