search

openzim / nautilus

Turns a collection of documents into a browsable ZIM file
GNU General Public License v3.0
19 stars 14 forks source link

Use python-scraperlib shared logic to handle description and long_description #64

Closed benoit74 closed 2 months ago

benoit74 commented 11 months ago

See https://github.com/openzim/python-scraperlib/issues/110 once implemented

HimaTeju commented 4 months ago

@benoit74 Is this issue fixed? Because here it is mentioned upgrade to 3.x already done.

benoit74 commented 4 months ago

No, issue still needs to be done. Upgrade to 3.x is already done like mentioned, but the upgrade of python-scraperlib still has to be done, including supporting description and long_description with the new compute_descriptions function introduced in python-scraperlib.

It is very important to note that first thing to do is hence to start the scraper locally and understand how it works, and observe the ZIM content with current codebase. Once the upgrade will be done, you will have to do the same and confirm there is no regression. We won't accept PR without details of manual tests executed.

HimaTeju commented 4 months ago

I don't know if this is the best place to enquire about this but, What is the best way to work with these Repos? I'm on windows 11, I got suggestions from the Slack community to use WSL. Can I use Docker or WSL is the best to work on this? (I'm new to Linux also)

rgaudin commented 4 months ago

WSL will allow you tu setup the dev environment directly. You can also install and use docker inside WSL I believe

HimaTeju commented 4 months ago

Thank you!

benoit74 commented 4 months ago

WSL is useful if you want to directly launch Python from your machine. Docker is the other alternative, does not need at all to be launched from within WSL. Docker Desktop or Rancher Desktop are probably good candidates to run Docker containers on Windows.

PS: this enquiry would be better placed on Slack, or at least in a new issue this has nothing to do with the fact that we need to use python-scraperlib shared logic to handle description and long_description.