search

openzim / nautilus

Turns a collection of documents into a browsable ZIM file
GNU General Public License v3.0
19 stars 14 forks source link

Clear Search Button in Reading #67

Closed kelson42 closed 5 months ago

kelson42 commented 5 months ago

From kiwix-android created by Sagar0-0: kiwix/kiwix-android#3658

Is your feature request related to a problem? Please describe.

I searched for a query and found the results but after that, I wanted to clear the search and get the whole list. Sadly, there was no button to clear the search filter and get back to the default state. photo_6107086600765814465_y

Describe the solution you'd like

When we have the same query we can have the clear button instead of the search button.

Describe alternatives you've considered

An alternative could be to use the cross(x) button in the text field to clear the search query and list.

kelson42 commented 5 months ago

Should I start working on it?

kelson42 commented 5 months ago

This is not the right repository to report this feature request. It should be in "openzim/gutenberg".

kelson42 commented 5 months ago

I mean this is UI related issue, right?

kelson42 commented 5 months ago

@Sagar0-0 This is not the Kiwix UI-related issue. This search is performed inside the ZIM file so the solution will be placed inside the ZIM file. I think we should move this ticket to "openzim/gutenberg" as @kelson42 mentioned.

rgaudin commented 5 months ago

@Sagar0-0 There is one when the text field is highlighted. Just tested with latest android nightly.

Please confirm. I'll close in the mean time.

Works in a similar way in https://library.kiwix.org/viewer#prunelle_budding_authors_en_2023-05/home except android version uses a dark theme which is making the logo disappear with this particular ZIM.