Closed Rishabhg71 closed 1 year ago
You should write .eslintrc.json
by hand instead of using tslint-to-eslint-config
. For some reason, tslint-to-eslint-config
recognizes this project as a Typescript project.
And using prettier is a good idea, IMO.
Yup prettier seems good but isn't this project in typescript? Only few files are in js
@RG7279805 I don't know😂. There are 3 typescript files and 4 javascript files, so I guess it's a javascript project? And two of typescript files are in the test
and eslint
will ignore them by default.
@kelson42 Sorry i was busy with some other things nonetheless you can do a review now and let me know if i messed up something
@RG7279805 Thank you @FledgeXu You seem competenter than I'm. Does it looks good to you?
@RG7279805 https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review ? Can you please reply in the discussions?
My bad @kelson42, I thought I did comment after making changes Thank you for the "pull request review" link i may have to learn more about GitHub
closes #89 I have added an eslint and eslintignore but there are some things with which I am not sure how to proceed with After adding an eslint file I am giving a lot of linting errors
To resolve some of the errors either I convert these files to .TS or ignore these options in.JS files like
Unsafe call of an "any" typed value
only way is convert to TS or JS (ignore)