openzim / node-libzim

Libzim binding for Node.js: read/write ZIM files in Javascript
https://www.npmjs.com/package/@openzim/libzim
GNU General Public License v3.0
27 stars 11 forks source link

Support libzim9 #118

Closed kelson42 closed 8 months ago

kelson42 commented 8 months ago

Unfortunately it fails because the getSize() of the iterator is now deprecated.

See https://github.com/openzim/node-libzim/actions/runs/7078395364/job/19263816211#step:6:2426

kelson42 commented 8 months ago

@mgautierfr What should be the approach here?

mgautierfr commented 8 months ago

Is SearchIterator::getSize (the wrapped version) is used somewhere (by a tool using node-libzim) ?

If not (what I hope) we should simply remove it. Another approach is to mark the (wrapped) function as deprecated also and (either):