search

openzim / node-libzim

Libzim binding for Node.js: read/write ZIM files in Javascript
https://www.npmjs.com/package/@openzim/libzim
GNU General Public License v3.0
27 stars 11 forks source link

Finish errant ESM upgrade #144

Closed audiodude closed 1 month ago

audiodude commented 1 month ago

The ESM conversion was only partially complete in #136. The PR #141 updated it to use the right import syntax.

This PR further updates the index.js file to use the right export syntax for ESM.

Additionally, we add a "dist" test that imports from the finished dist/ folder. This ensures that everything is "hooked up" properly and that all the symbols can be properly imported.

This PR should be released immediately as 3.2.3, because the exports are broken in 3.2.2. (And maybe the changelog should reflect that 3.2.1 and 3.2.2 are faulty).

Sorry!

kelson42 commented 1 month ago

@audiodude Please go ahead with merge and release if you want

audiodude commented 1 month ago

@kelson42 I don't have permission without review