openzim / node-libzim

Libzim binding for Node.js: read/write ZIM files in Javascript
https://www.npmjs.com/package/@openzim/libzim
GNU General Public License v3.0
27 stars 11 forks source link

Move to https://nodejs.org/api/n-api.html #31

Closed kelson42 closed 4 years ago

kelson42 commented 4 years ago

nbind is not supported and N-API seems mature/good enough

kelvinhammond commented 4 years ago

@kelson42 is this still an issue?

kelson42 commented 4 years ago

@kelvinhammond Thank you very much again for this really important fix. @midik is currently working on a release of it which should be used in next MWoffliner minor release (in the next days). I have as well open a ticket to rearchitecture that binding in a way which is more respectful of libzim design, see #36.