search

openzim / node-libzim

Libzim binding for Node.js: read/write ZIM files in Javascript
https://www.npmjs.com/package/@openzim/libzim
GNU General Public License v3.0
27 stars 11 forks source link

Move to libzim7 #72

Closed kelvinhammond closed 2 years ago

kelvinhammond commented 2 years ago

Fixes #69 Fixes #79

This is a work in progress. The test script is what I'm using to test things as I develop, I'll add proper tests later. Once I figure out the threading issues I'll remove / cleanup the code.

Let me know if you want the API changed. I went with accessor methods for some of the C++ class methods because that is the current javascript style. This code could be dried out with all the try catch stuff but then it ends up looking a bit unwieldy so its not dry for readability and flexibility in this way.

kelson42 commented 2 years ago

@kelvinhammond Agree with you, but before merging, can you please open a ticket with a clear description of the problem/regression please?

kelvinhammond commented 2 years ago

@kelson42 issue here https://github.com/openzim/node-libzim/issues/80