mgautierfr
commented
5 years ago This would means that there is only one ZimReaderWrapper.
The static inside the method means that rw is stored in a static memory (ie a global memory common to all "call" to create).
On a more global pov, why the wrapper is needed at all ? It simply store a zim::File and does nothing as all the code is in the zimReaderManager and directly use rw->_reader. You would better to remove the wrapper and make zimReaderManager directly interacte with a zim::File instead of a ZimReaderWrapper. Or move the code in the wrapper and have the manager only managing wrapper (create them, delete them) and not doing interaction with the thing wrapped. (But in this case, you can simply have a simple function to create the wrapper, no need for a class)
This is the same problem with the ZimCreatorWrapper
You have to be carreful here. I don't know how nbind and node are doing it, but you are not taking any reference to the buffer buf. If you lose all reference in the js word, the gc will clean buf object and you will have dangling pointers to some random memory.
Be carreful, zimCreator is not thread safe. You must use it from only one thread.
There is a lot of promise, async in your js code and I'm not sure this is compatible.
ISNIT0
Hi @mgautierfr, I would really appreciate your review of this CPP code. I have very little knowledge of best practices, and I feel there are likely to be silly errors!
(CC'd: @kelson42 )