Closed kelvinhammond closed 1 year ago
@kelvinhammond Which bug does it fox? There is no ticket linked to this PR.
@kelson42 It fixes this bug https://github.com/nodejs/node-addon-api/issues/1174#issuecomment-1423250863 that was found by @kevineady
@kelvinhammond Great, this huge!!! @mgautierfr Please have a look so we can move forward with the release.
Error reported here https://github.com/nodejs/node-addon-api/issues/1174#issuecomment-1423250863
This fixes the use after free memory issue with the blob object by creating a shared_ptr for the new blob's data that blob will then own.