openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Fix invalid internal links #111

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

This fixes #105 by returning the download status (success/failure) from download_file() and using the result to decide whether to rewrite a link.

However, even after this, some weird mailto: links are still invalid and that's due to a bug with scraperlib. I've opened https://github.com/openzim/python_scraperlib/issues/46 for that

Also, there's a script which has a template and that's actually identified by zimcheck wrongly as an invalid link (and thus it's large number, as it's present in every HTML file with PHZH ZIMs). Have opened https://github.com/openzim/zim-tools/issues/149 for that.