search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Hide kiwix-serve taskbar in embedded iframes #135

Open IPECORE opened 4 years ago

IPECORE commented 4 years ago

If I click on one of the 3 "icons" or texts in this line, it brings me back to the start. You can just delete it. unnecessary line between text and illustration

satyamtg commented 4 years ago

@IPECORE are you talking about this -

91179477-d5ad6a80-e6e6-11ea-9939-f04c58e03016

If yes, then that's nothing to do with the ZIM but with kiwix-serve, as that puts this frame around iframes it seems. @rgaudin what do you suggest?

rgaudin commented 4 years ago

Absolutely.

@IPECORE, this is a kiwix-serve specific issue. This is not show in other readers (iOS, desktop, android).

The workaround we have at the moment, is to add partial=true to the MIME type of iframes'HTML articles (text/html obviously). We can't do that in zimwriterfs-like mode (nor in plain zimwriterfs). Once we move away from this mode, we could be able to set it and that annoying bar would not be shown.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.