search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Fix encoding to WebM with low quality #157

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

The missing videos were due to two reasons -

  1. When passing low quality, conversion didn't take place (the conversion code was in the elif block, which was incorrect)
  2. The thumbnail was actually being passed for conversion instead of the video file.

This fixes #145 by disabling thumbnail download (we didn't use them anyway), and by moving the conversion code to the right place.