openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Fixes #160 - Fail properly on downloads #164

Closed satyamtg closed 1 year ago

satyamtg commented 4 years ago

Will potentially fix #160. Will update description after testing.

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 3 years ago

@satyamtg Any chance this PR could be easily completed?

satyamtg commented 3 years ago

@satyamtg Any chance this PR could be easily completed?

Yep. I'll test once and push updates.

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 3 years ago

@satyamtg Any chance you could find a few hours to complete this PR please?

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

benoit74 commented 1 year ago

Probably superseeded by #178 which is working ok (the code in this PR was fairly limited to only few kinds of resources, the one in #178 is way more generic)