search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Scraper incorrectly labels zim language to English #165

Closed Popolechien closed 3 years ago

Popolechien commented 3 years ago

Just noticed that both PHZH OpenedX MOOCs in Arabic and Greek are labeled (and found) as English https://farm.openzim.org/recipes/phzh_core-arabic-one https://farm.openzim.org/recipes/phzh_core-greek-one

Screenshot_20201126_165219

See https://github.com/openzim/zimfarm/issues/563

kelson42 commented 3 years ago

The ZIM metadata seems indeed wrong https://library.kiwix.org/phzh_core-arabic-one-test-zim_ar_2020-11/M/Language

kelson42 commented 3 years ago

Not sure but he conf language is in ISO2.... maybe the error comes from that. See https://farm.openzim.org/recipes/phzh_core-arabic-one/config

kelson42 commented 3 years ago

A proper oprion name should be --language

rgaudin commented 3 years ago

There is no language option, as mentioned in my first answer. Locale is for the UI, not the content.

Not familiar enough with codebase to say whether it's possible/wanted to have a dual purpose language option or if we should have two separate ones.

kelson42 commented 3 years ago

The UI should be in sync with the content.

satyamtg commented 3 years ago

just saw that's because of "eng" mistakenly being hardcoded in the code. Fixing.